Lightrun
question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ListingTable onRowClick reacts to "mousedown", not "click"

See original GitHub issue

As @redallen explained:

Looks like this was a hack added in #1227 for inline editing. @suomiy said here:

inline edit needs input events. I can send back computedData which are a bit easier to consume and leave the decision logic on consumer. IMO this is the best what can be done. Does somebody have a better idea?

If inline-edit-extension works with changing the event we can convert it to onClick.

So, however the however the hack was introduced to make inline-edit-extension work i think it’s erally obscure behavior for normal row clicks to react on mousedown.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
KKoukioucommented, Oct 29, 2021

Yes, I confirm it’s fixed.

0reactions
nicolethoencommented, Oct 28, 2021

@KKoukiou I wanted to check if this is still an issue - given that the onmousedown listener has been replaced with an onclick here.

It was a change made as a part of this PR

Read more comments on GitHub >

github_iconTop Results From Across the Web

Storage ListingTable onRowClick reacts to "mousedown", not ...
When clicking on a row in the Filesystems table in the Storage page, navigation happens already on the mousedown event, not on a...
Read more >
React OnMouseDown event is not working whereas ...
class Hello extends React.Component { onDown() { console.log("Down"); } onClick() { console.log("Click"); } render() { return ( <div> <svg > ...
Read more >
Mouse events - The Modern JavaScript Tutorial
Mouse event types. We've already seen some of these events: mousedown/mouseup: Mouse button is clicked/released over an element.
Read more >
.mousedown() | jQuery API Documentation
The mousedown event is sent when any mouse button is clicked. To act only on specific buttons, we can use the event object's...
Read more >
React Mouse Events — Clicking, Dragging and Dropping, with ...
Here's one way you might use events in React: This is mine, but I hope it's generic. Idiosyncrasy is not a code goal....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found
Previous page

Usage of a blue color in a tree view

Next page

SVG icons, especially those of different sizes, are not properly aligned