Mssing default props

It looks like when a lot fo components were transformed to TS a lot of them started to use default parameters instead of defaultProps.

This causes several problems

• snapshots changed when consumers used mount - a lot of unnecessary snapshot changes needs to be applied
• React extension is not usable for lot of components - if component does not set defaultProps it will not display them in React extension. This might seem as a minor issue, but that is actually really usefull when you are using these components as you can change props on the fly. Before After

Even though it is correct to use default parameters instead of default props, for better code style and consistency it’s better to use default props. And of course the great benefit of helping developers to use PF4 components.

[redallen]

@karelhala I’m thinking that this can be a part of our greater move to using tsc instead of babel and that we could write it as a TypeScript transform plugin. Let me explain.

Currently, to generate propTypes, we use babel-plugin-typescript-to-proptypes which I find less than ideal. @TheRealJon and I have found numerous errors and inconsistencies in its behaviour. Our own extension can add whatever we want to the JS (propTypes, defaultProps, etc.) and we can enforce proper behaviour and handle function components however we want.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.