incorrect Dispose function

Hi,

the code that actually makes the disposing of an ExcelQueryFactory is never called because of this condition on the begining of the function

    protected virtual void Dispose(bool disposing)
    {
        **if (!_disposed) // this is not ok, should be if (_disposed)
            return;**


           //this is never called because _disposed is always false
            if (disposing)
            {
                if (_queryArgs != null && _queryArgs.PersistentConnection != null)
                {
                    try
                    {
                        _queryArgs.PersistentConnection.Dispose();
                        _queryArgs.PersistentConnection = null;
                    }
                    catch (Exception ex)
                    {
                        _log.Error("Error disposing OleDbConnection", ex);
                    }
                }
            }

        _queryArgs = null;
        _disposed = true;
    }

[buda56]

It also leaves a locked file until the application using the add-in is closed. In my circumstance I was using it in a service on a thread, once I accessed the file to read it thew file remained locked event though the thread and class had been terminated. As the service is still running the lock is maintained, doesn’t release until the service is restarted.

Peter

[mrworkman]

Ah, sorry. I’ve had a lot going on in the last year. It’s been hard to get any time to work on this project 😢