Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Typing

See original GitHub issue

I’m hoping to gradually improve the ‘typing’ in this library to the point where it can be linted using Mypy.

There’s quite a lot to do first! This library uses a few loosely-typed data structures which lead to a lot of type errors. That will possibly involve some refactoring (or heavy use of if not None checks everywhere).

I’ll use this is as a parent task for various efforts to improve the typing-

Issue Analytics

State:
Created 3 years ago
Comments:12 (9 by maintainers)

Top GitHub Comments

3reactions

frostmingcommented, Jun 23, 2021

Here is the good news: all type errors in the codebase are cleared #517

Thanks all

2reactions

frostmingcommented, Apr 30, 2021

I never disregard type hints, I myself also improved the types and reduced the error number by ~100. Everyone can contribute to improving this and I am glad to review it.

This isn’t really working.

Don’t urge on that, many errors were introduced by a patch that applied types from an automation tool(pyannotate). Keep on the good work and we will finally get the green flag to add mypy in pre-commit and CI!