Prohibited branch detection does not work
See original GitHub issueDescribe the bug
When users set a publish_branch
that is the same as a branch triggered by the workflow, this action stops the deployment to protect the branch.
Currently, this protection behavior does not work.
To Reproduce
With peaceiris/actions-gh-pages@v3
on:
push:
branches:
- master
...
publish_branch: master
Expected behavior
This Action should return the error You deploy from master to master
Screenshots
Your YAML file
- A link to your repository: https://github.com/peaceiris/test-mdbook
- A link to your YAML file: https://github.com/peaceiris/test-mdbook/actions/runs/85307348/workflow
- A link to your workflow log: https://github.com/peaceiris/test-mdbook/runs/610595170?check_suite_focus=true#step:6:116
Additional context I found this bug in this article: AsciidocのドキュメントをGitHub Actionsを用いてGitHub Pagesで公開する。 - Qiita
This protection should be also implemented for personal_token
, deploy_key
, and eventName === 'pull_request'
.
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (4 by maintainers)
Top Results From Across the Web
Protected branches - GitLab Docs
No one can delete a protected branch using Git commands, however, ... For merge controls to work properly, set Allowed to push to...
Read more >remote: GitLab: You are not allowed to push code to protected ...
You can turn on and off protection on selected branches in Project Settings (Go to project: "Settings" -> "Repository" -> "Expand" on "Protected...
Read more >Part A. Requirements for all Mortgagees - HUD
This constitutes a prohibited branch arrangement. Separate entities may not operate as “branches” or “DBAs” of a FHA approved mortgagee.
Read more >Fair Lending Laws and Regulations - FDIC
laws, a lender may not, because of a prohibited factor: ... In order to detect any disparate ... and such issues as branch...
Read more >TSA Has Policies that Prohibit Unlawful Profiling But Should ...
Screeners are prohibited from picking passengers based on factors ... These complaints are not specific to behavior detection activities.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@peaceiris, thanks for following up. I see my mistake. I think the README is clear now.
This issue has been LOCKED because of it being resolved!
The issue has been fixed and is therefore considered resolved. If you still encounter this or it has changed, open a new issue instead of responding to solved ones.
<div align="right">Log | Bot Usage</div>