Clicking on a result item passes the click event onto the map

When clicking on the drop down results, the click event is passed onto the map.

On line 206 of control.js I’ve changed:

L.DomEvent.addListener(li, 'mousedown', clickHandler, this);

to

L.DomEvent.addListener(li, 'click', clickHandler, this);

which resolves the issue.

On line 189 of control.js:

clickHandler = function clickHandler(e) {
  L.DomEvent.preventDefault(e);
  this._geocodeResultSelected(result);
};

preventDefault(e) prevents the mousedown event propagating but not the click event. I’m not sure if this is the best way to resolve it.

I’m working with the version 1.5.1

[perliedman]

For me (Chrome 53/Ubuntu 16.04), changing from mousedown to click does not fix the bug (still get a click event on the map), but also prevents the control from working - you can no longer select a result from the dropdown (presumably since blur fires before click, so the result is removed before the click can reach it.

[perliedman]

@domialex if you read above, the problem with that approach is that it used to be click, but was changed since it caused problems: https://github.com/perliedman/leaflet-control-geocoder/commit/cc1a049617a3b03a181cb23305dcb297f7f155bf

Can’t say for sure if that is still a problem or not, if it’s just a problem in some browsers, etc., but I’m wary of just changing this without some thorough testing. Personally, I’m sorry to say that I don’t have the time to do that at the moment, but help would be welcome!