Question about manual data update

I wonder why in the manual update case the removeMissing option is not taken into account here ?

Indeed it is very convenient to let the plugin manages this for you in most use cases instead of having to manually split features between added/removed ones. If you still want to use this manual workflow simply set the removeMissing option to false.

This way it seems to me the API is more coherent to what is done when data fetching is delegated to the plugin here. However, I also understand this is a breaking change to endorse…

[claustres]

Well I was thinking to simply replace this line by this._onNewData(this.options.removeMissing, geojson) since the _onNewData() method already provide the flag and this will be similar than with auto-updates.

However this is a breaking change, so we might add a flag in the update method as you seem to propose and keep the old behavior like this:

update: function(geojson, removeMissing) {
    ...
    if (geojson) {
        this._onNewData(removeMissing, geojson); // Defaults to false if option not defined
    } else {
        responseHandler = L.bind(function(data) {
            // Will allow to temporarily override layer option if provided
            this._onNewData(typeof removeMissing === 'undefined' ? this.options.removeMissing : removeMissing, data);
        }, this);
        ...
    }

    return this;
}

What do you think ?

[perliedman]

Closing this since I believe it is fixed by #127.