Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use func.qualname instead of func.name

See original GitHub issue

By using func.__qualname__ instead of func.__name__ we can apply the decorator to methods and get unique keys including the class’ name.

For example if we have two classes with a method with the same name, and we apply @cache_memoize to both of them the same cache key will be used, unless we explicitly use prefix. But IMHO doing as suggested is a safe default.

Just noticed that for Python 2 this would require adding some dependency like https://pypi.org/project/qualname/

Issue Analytics

State:
Created 5 years ago
Comments:11 (6 by maintainers)

Top GitHub Comments

1reaction

Geekfishcommented, Jan 24, 2019

Right now we’re not suffering.

Agreed. I think it would be nice to upgrade, as you said, regardless. Since __qualname__ is a “breaking change” it could easily fit in this, and it’s a nice improvement as users will need have one less concern in their heads.

I’ll open a separate issue for the upgrade, and we can come back to this as well.

0reactions

Geekfishcommented, Jun 11, 2019

Yeap, I think it should now be just a drop in replacement 😃