Using bluebird to promisify Node's http.request?

Can anyone help me promisify Node’s http.request with bluebird?

Here is my try:

var http = require('http');
var Promise = require('./framework/libraries/bluebird');
var PromiseRequest = Promise.promisify(http.request);

var myRequest = PromiseRequest({
    method: 'GET',
    host: 'nodejs.org',
    port: 80,
    path: '/',
}).then(function(value) {
    console.log('value:', value);
});

console.log('myRequest:', myRequest);

Unfortunately this code never completes and the ‘then’ callback is never executed.

@petkaantonov - love the library! Especially how performant it is!

[kirkouimet]

@benjamingr LOL, I literally was writing this when your response came in on my email:

// Resolve the promise when the response ends
response.on('end', function() {
    resolve(result);
});

Thank you!

[kirkouimet]

@benjamingr thanks! You sent me in the right direction. Can you take a second to review this code and let me know if I am doing anything weird or incorrectly?

var http = require('http');
var Promise = require('bluebird');

var PromiseRequest = Promise.method(function(options) {
    return new Promise(function(resolve, reject) { 
        var request = http.request(options, function(response) {
            // Bundle the result
            var result = {
                'httpVersion': response.httpVersion,
                'httpStatusCode': response.statusCode,
                'headers': response.headers,
                'body': '',
                'trailers': response.trailers,
            };

            // Build the body
            response.on('data', function(chunk) {
                result.body += chunk;
            });

            // Resolve the promise
            resolve(result);
        });

        // Handle errors
        request.on('error', function(error) {
            console.log('Problem with request:', error.message);
            reject(error);
        });

        // Must always call .end() even if there is no data being written to the request body
        request.end();
    });
});

var myRequest = PromiseRequest({
    method: 'GET',
    host: 'www.nodejs.org',
    port: 80,
    path: '/',
}).then(function(value) {
    console.log('value:', value);
});