Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] List height does not update when items size changes without transitions

See original GitHub issue

Describe the bug Similar to https://github.com/petyosi/react-virtuoso/issues/314, the list height does not update as expected even when not using transitions.

Reproduction https://codesandbox.io/s/aged-resonance-evq3r

Workaround Adapted with rerender parent component approach see https://github.com/petyosi/react-virtuoso/issues/322#issuecomment-807428391 https://codesandbox.io/s/twilight-grass-12d1d

To Reproduce Steps to reproduce the behavior: Find Item e.g. 14, Click on expand and collapse again

Expected behavior The scrollbar should have disappeared when the list height has been updated accordingly.

Screenshots

Desktop (please complete the following information):

Tested in Mac OSX
Tested in Chrome

Issue Analytics

State:
Created 2 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

2reactions

petyosicommented, Mar 26, 2021

Yes, it is a bug. I will look into it. A thing to notice though is that keeping state in the individual item is not a good idea. If you scroll beyond the current set of items, they will be unmounted, thus, their expanded state will be lost.

1reaction

chamerlingcommented, Apr 30, 2021

Great, this also fixes issue I was looking at when a sub component is lazy loading image with unknown height. Great job, thx for this 🍺