Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Can't delete/remove unloaded plugin

See original GitHub issue

Hi, I found a little issue. I don’t know if it’s only on my end.

How to reproduce it:

Start the application and install a plugin
After installing it, deactivate it
Restart your application -> The plugin won’t be started by application
Try to delete (pluginManager.deletePlugin(plugin.getPluginId());) the plugin.
A ClassNotFoundException is thrown

If I activate the plugin and then tries to delete/remove it there is no issue. The same if I activate the plugin and then deactivate it again and then tries to delete/remove it.

The problem occurs only if I try to delete/remove a plugin which was not loaded/started by application with application-start.

Tested on macOS 10.14.4 with Java 1.8.0_202

Issue Analytics

State:
Created 4 years ago
Comments:10 (6 by maintainers)

Top GitHub Comments

2reactions

decebalscommented, Apr 10, 2019

The problem is related to https://github.com/pf4j/pf4j/issues/242 (Add delete hook method in Plugin). I will take a look and I will come with a solution asap.

1reaction

decebalscommented, Apr 13, 2019

I think that I found a solution to solve the problem in an elegant mode with few modifications. My idea is to retrieve the plugin instance before the plugin will be unloaded. See below the modifications as diff:

@meydominic Please make above modifications on your machine. Build and test the new PF4J version on your use case (application). If the result is OK please let me know to commit the modifications on GitHub. Thanks!