Typescript package not generating strict checks

👋 This is a really amazing tool. Seriously, I’m super excited you’re building it and I’d love to help out.

I tried to integrate it into one of Artsy’s repos. You can see the PR here: https://github.com/artsy/reaction/pull/2864.

If you clone reaction and (after running yarn) run

tsc --noEmit --pretty --strict

you’ll see a lot of errors. If you just run…

yarn betterer

the snapshot won’t contain any. I’m not 100% sure what’s happening here… I did notice that you had typescript as a direct dependency of @betterer/typescript which it might not need to be… I tried upgrading our version of ts (which needed to be done anyway) and adding a resolution but that didn’t change things.

Likely, I suspect that not all of the tsconfig is getting copied over. I can try to investigate more tomorrow.

This is exciting! 🎉

[phenomnomnominal]

Or you can bump to @betterer/typescript@0.1.6 and that will fix the TypeScript dependency too ☀️

[phenomnomnominal]

Cool, I think I’ve fixed this, you’ll need to bump to @betterer/typescript@0.1.5, let me know if that works!