Primary Key missing in auto-generated migration

Using Postgres & Piccolo 0.32.0, the auto-generated migrations fail to include the primary key.

Schema:

from piccolo.table import Table
from piccolo.columns import ForeignKey, UUID

class Types(Table):
    id = UUID(primary_key=True)

class Things(Table):
    type = ForeignKey(references=Types)

When I try to run migrations via:

piccolo migrations new my_app --auto
piccolo migrations forwards all

I get:

Running MigrationManager ...
The command failed.
foreign key constraint "things_type_fkey" cannot be implemented
DETAIL:  Key columns "type" and "id" are of incompatible types: integer and uuid.

Looking at the generated migration, I see:

class Types(Table, tablename="types"):
    pass

Adding the PK manually to the migration fixes the issue:

class Types(Table, tablename="types"):
    id = UUID(primary_key=True)

[dantownsend]

I think the issue here is the ForeignKey should be created with type UUID, otherwise it can’t store the reference to a UUID primary key.

This should work - I’ll investigate what went wrong.

[aminalaee]

@adriangb That’s fine I think. We didn’t really have an issue for that PR. Thanks for reporting it.