Convert number to string

can you check if (typeof input === 'number') input = input.toString();?

e.g. getSlug(44) should output '44' but it outputs ''

[simi]

Yeah, this is 2 extra lines of code. Then someone will came here and ask to add another two lines for another data type. In the end, there will be big condition handling all those types.

What I suggest is to keep it in this way as it is now and move that responsibility outside of this library. In API docs is written that getSlug expects string. You need to handle that in your code.

If you need to pass number in there, you can introduce your own wrapper on top of the getSlug for example or call toString() before passing to getSlug.

I’m 👎 on this feature since it will solve your problem, but it will add some complexity not used in 99% usage.

[pid]

But, this ticket opens another question, should getSlug return/throw an error if input is not a string or return false? To return an empty string feels not the best… what you are thinking about? Should we change this?