Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Refactor] Filter actions

See original GitHub issue

We should make a couple changes to the current Filter action:

Add an optional “Reason” prop, and set the default to Condition met for exiting [or continuing] workflow
Break out the current Filter action into 3 different actions and get rid of the continue prop:

“Continue workflow based on a condition” (filter-continue-workflow-condition)
“End workflow based on a condition” (filter-end-workflow-condition)
“End workflow” (filter-end-workflow)

Issue Analytics

State:
Created a year ago
Comments:8

Top GitHub Comments

1reaction

dannyrooseveltcommented, Apr 26, 2022

@andrewjschuang why don’t you go ahead and get this published now since we just announced it (and I’ve been testing them), then @DilanAthukorala you can still run through QA after it’s out

@dannyroosevelt can you approve the fix I pushed yesterday to the PR?

Done

1reaction

andrewjschuangcommented, Apr 26, 2022

@andrewjschuang why don’t you go ahead and get this published now since we just announced it (and I’ve been testing them), then @DilanAthukorala you can still run through QA after it’s out

@dannyroosevelt can you approve the fix I pushed yesterday to the PR?

Top Results From Across the Web

[ACTION] Refactor Filter Action · Issue #4427 · PipedreamHQ ...

We've gotten consistent feedback from users that the Filter actions are confusing to use. I think they're probably overly complex, and can likely...

lodash refactor filter function - typescript - Stack Overflow

I have the following code, both components use a lodash filter, how do I abstract the function so I dont repeat the code?...

Actions defined by AWS Migration Hub Refactor Spaces

Actions Description Access level Resource typ... CreateEnvironment Grants permission to create an environment Write DeleteEnvironment Grants permission to delete an environment Write environment* DeleteEnvironment Grants permission...

The Best Refactoring You've Never Heard Of - YouTube

Letting a search procedure take an arbitrary filter function, instead of ... a user stop in the middle of an action — and...

Refactoring Reducers Example | Redux

switch (action.type) { case 'SET_VISIBILITY_FILTER': { return Object.assign({}, state, { visibilityFilter: action.filter } ...