Routes are incorrect when hosted in Virtual Directory

Related to #1273. The application starts after the fix done to IntegratedMiddleware but routes are incorrect, so navigating to any page except the default site page fails - or even the main page URL is incorrect when clicked in the menu.

HttpContext.Request.PathBase contains the Virtual Directory path, so I’ve tried to do some changes to make use of that value, but I haven’t found the correct place(s) to modify. It looks like route handling is correct, so the pages are found and rendered correctly if the browser URL points to the <host>/<virtual-directory>/<page>, however the menu items don’t include the <virtual-directory> segment.

I’ve just modified the MvcWeb application in the examples folder to debug this:

[tidyui]

I added a comment to your PR!

[tidyui]

My guess is the menu can be fixed easily in the project. The templates render the menu like this:

https://github.com/PiranhaCMS/piranha.core.templates/blob/master/src/web/razor/Pages/_Layout.cshtml#L25

Where permalink will start with a forward slash. By adding a “~” before permalink and wrapping it inside @Url.Content() asp.net should resolve the links correctly.

We’re adding some helpers for link generation in 8.4, we’ll try to test for this case as well.

Regards