Breaking changes from PIXI.mesh.Plane to PIXI.SimplePlane

Dear Pixi friends,

It looks like something has changed when moving from PIXI4 class PIXI.mesh.Plane to PIXI5 class PIXI.SimplePlane that makes it unable to distort some kind of textures. I used this Pen from Blake Bowen https://codepen.io/osublake/pen/8785174690eabaf5ba99f785b9d3b64e and I changed it just enough so it works on PIXI5. And I got it working. The changes are:

- - - Change 1:

Original Code (Pixi 4): var grid = new Grid(rows, cols, width, height, beach.vertices);

Changed Code (Pixi 5):

  const buffer = beach.geometry.getBuffer('aVertexPosition');
  var grid = new Grid(rows, cols, width, height, buffer.data);

- - - Change 2:

Original Code (Pixi 4):

  var tl = new TimelineMax({ 
    repeat: -1,
    onUpdate: grid.update, 
    callbackScope: grid
  });

Changed Code (Pixi 5):

  var tl = new TimelineMax({ 
    repeat: -1,
    onUpdate: ()=>{buffer.update();grid.update();}, 
    callbackScope: grid
  });

And that was enough to get it working: https://codepen.io/is2548-the-selector/pen/JjbWjaG

But, I discovered something strange that prevents the example from working. If you change the texture for PIXI.Texture.WHITE, it works on PIXI4, but stops working on PIXI5:

PIXI4(working): https://codepen.io/is2548-the-selector/pen/eYBvYbq PIXI5(not working): https://codepen.io/is2548-the-selector/pen/JjbWojb

And this does not happen only with this texture. I found out another texture that SimplePlane can’t warp, like this texture:

const video = document.createElement("video");
video.src = "path/to/video.mp4"
document.body.appendChild(video);
const texture = Texture.from(video);

(although this texture works for distorting a video using PIXI.projection.Sprite2s using proj.mapBilinearSprite)

Any clues about how to fix this? Is it a Pixi bug or an error on my side 😃 ?

Thank you! Alexandre Rangel https://www.alexandrerangel.art.br

[bigtimebuddy]

Adding this line it works:

beach.textureUpdated();

Example: https://jsfiddle.net/bigtimebuddy/9ngx82Ld/

I think the issue is this check:

https://github.com/pixijs/pixi.js/blob/2a47593194043fa86a601cb4282105fa6c3472cc/packages/mesh-extras/src/SimplePlane.ts#L61-L68

Since, MeshMaterial is already using a default texture of PIXI.Texture.WHITE, the texture is not updated. I believe this is a bug (tho, not a critical one). Thanks for finding this one @AlexandreRangel

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.