Multisampled textures not handled at all in PixiJS internally

@ivanpopelyshev When you created multisampled textures with renderbuffers, you introduced an extra step in the render process:

msaaTexture.framebuffer.multisample = 16;

renderer.render(displayObject, msaaTexture);
renderer.framebuffer.blit();

This makes it very problematic to the extent that PixiJS itself fails to take care of this extra step in masking.

No blit here: https://github.com/pixijs/pixi.js/blob/064135e795dbfe7b53248ff457d71cb8536077ac/packages/core/src/mask/StencilSystem.ts#L93

@bigtimebuddy I would propose that we do a blit in renderer#render and save the user all future hassle. What do you think?

Pen 🖊️

Here’s an example that fails with masking (comment out graphics.mask = mask, and it’ll work):

https://codepen.io/sukantpal/pen/abNwBoN

[GoodBoyDigital]

both good! no super strong opinion. probably option one! something for next major version?

[ShukantPal]

We should also create a “renderer.flush” method so users don’t have to both flush the batch renderer and blit the framebuffer after rendering a display-object.

On Sep 12, 2020, at 6:12 AM, Matt Karl <[e-mail]:[e-mail]> wrote:

I’m in favor of options for render. What do you think about these two signatures?

render(displayObject, options) render(displayObject, renderTexture, options)

Where options is:

• clear
• transform
• skipUpdateTransform
• blit (proposed)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/pixijs/pixi.js/issues/6844#issuecomment-691462257, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFLJDB3SI4HC7NH4VV4UJIDSFNCRTANCNFSM4QOU52EA.