question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposal (work-in-progress): extended filter system features

See original GitHub issue

Our team has uses a modified version of pixi.js’s FilterSystem. We are adding new features that might be useful to other users, and we were looking to know if this would be accepted into the main codebase or as a plugin.

pixi-extended-filter-system package repo is here: https://github.com/phase-software/pixi-extended-filter-system/tree/master/src

Currently, we have added these feature(s):

  • measure pass: pixi.js has two options for the input frame given to a filter - the “object + padding” or its intersection with the screen. There is no intermediate. This can cause performance problems, since autoFit=false filters needlessly apply on the whole object. By allowing the filters to measure their required input, we eliminate this issue. (Note: the input is never outside the object being rendered, and this is enforced in our repo).

  • returning a texture other than output: In multi-pass filters like the kawase-blur, passes are done in a flip-flop basis. If the number of passes are even, then we cannot use the input & output textures to do the passes (since we would end on the input texture). If we allow filters to return output textures (other than the given output texture), we could eliminate extra texture allocations in filters like the drop-shadow & blurs. Of course, sometimes we cannot change the output texture (like in the case of the very last filter, which applies to the screen). We can specify whether returning an alternative output texture Is allowed with a filter-manager property.

  • providing a custom geometry to FilterSystem#applyFilter.

  • pipeline support: in order to simplify building multi-pass filters, we should create an API that allows filters to change the input/output for each pass.

Sidenote: I would like to reference this issue from pixi-filters, and ask that pixi devs consider allowing that feature into the pixi-filters codebase: https://github.com/pixijs/pixi-filters/issues/231

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
ivanpopelyshevcommented, Nov 26, 2019

You are on a right path. I have custom FilterSystem that has second feature.

0reactions
stale[bot]commented, Mar 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Read more comments on GitHub >

github_iconTop Results From Across the Web

artivis/kalmanif: A small collection of Kalman Filters ... - GitHub
It is developed as a header-only C++17 library based on manif. At the moment, it implements: Extended Kalman Filter (EKF); Square Root Extended...
Read more >
JWST Guidelines and Checklist for Proposal Preparation
A description of which items are requested as well as guidelines for answers are presented in JWST Filling Out the APT Proposal Form....
Read more >
EKFPnP: Extended Kalman Filter for Camera Pose Estimation ...
This paper presents some 'work in progress' towards a multi-camera person tracking solution. The tracking system aims to combine observations ...
Read more >
Cleanroom Fan Filter Features Comparison - Terra Universal
Compare cleanroom fan filter types and FFU features including airflow design, size, motors, construction, control systems, and compatible accessories.
Read more >
Emergency Response Systems: Concepts, features ...
argued to extend well beyond actors directly involved in the productive ... system proposed by Hollnagel and Woods is unsatisfying, stating that it...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found