syncUniforms stopped working on Chrome Dev channel
See original GitHub issueHey everyone! I’m trying to trace down a change in Chrome that causes my global uniforms to no longer work.
What I’m doing: I’m adding matrices as 16-entry arrays to renderer.globalUniforms
for 3D stuff. In the past this worked just fine, but it broke in Chrome Canary and now also in the Chrome Dev channel.
The error is of the form:
TypeError: Cannot read properties of undefined (reading '17')
at ShaderSystem2.syncUniforms (ShaderSystem.ts:152:32)
at ShaderSystem2.syncUniformGroup (ShaderSystem.ts:140:18)
at eval (eval at generateUniformsSync (generateUniformsSync.ts:269:12), <anonymous>:11:41)
Somehow the code-generation for syncing uniforms is different (?) on Chrome 108 causing the array to be interpreted as a UniformGroup, causing the above error.
I briefly tried the latest 6.x version of pixi and the error happened there as well.
Before embarking on building a repro case, I wanted to see if others have noticed issues with uniforms on the Chrome Dev channel. Also, I’d be grateful for pointers regarding correct use of globalUniforms, as I couldn’t find anything in the docs and I don’t understand the source well enough yet.
Environment
pixi.js
version: 6.5.1- Browser & Version: works in Chrome 105 and 106, also in Firefox, but is broken in Chrome 108
- OS & Version: Windows 10
Issue Analytics
- State:
- Created a year ago
- Comments:7 (3 by maintainers)
I’m happy to report that my issue has been fixed in Chrome 109 (Canary and Dev channels) and never landed in mainline Chrome releases. This issue can be closed.
Thanks! @SuperSodaSea Ill see if i can apply the same workaround or just fork that filter.