Wrong default port for ESP32 OTA

The current documentation states:

–port=ESP_PORT ESP32 OTA Port. Default 8266

And then only if there are problems to use

upload_flags =
    --port=3232

However, the current default upload port for Arduino OTA is 3232.

https://github.com/espressif/arduino-esp32/blob/a070884441308c5bfa6805d6f515801769ea0b1b/libraries/ArduinoOTA/src/ArduinoOTA.h#L34-L35

https://github.com/espressif/arduino-esp32/blob/a070884441308c5bfa6805d6f515801769ea0b1b/libraries/ArduinoOTA/src/ArduinoOTA.cpp#L101-L109

In fact the default port has always been 3232 in the implementation, though the first commit wrongly says 8266 in a comment (here) because it was pretty much copied from the Esp8266 version. This commit corrects that.

Therefore I think that for the ESP32 platform, the default upload port should be set to 3232, and the documentation should extended to double check the upload port (which can be customly set by calling setPort()) if upload errors occur.

Also see discussion here: https://community.platformio.org/t/esp32-ota-via-ethernet-doesnt-want-to-work/8308/20?u=maxgerhardt

[pfeerick]

The PR is against the espressif/arduino-esp32 core, not platformio, as the fix is needed there: https://github.com/espressif/arduino-esp32/pull/2948/commits/36bc34015c34deae1a266f85e2f8521b81dabd08

Most of the changes are documentation, but line 260 is also a change in behaviour. This will change the default port used by espota.py to 3232, so that it doesn’t need to be overridden via-p 3232, and PlatformIO and other third party tools will be able to use the correct port by default also.

[maxgerhardt]

@pfeerick Alright thanks if the code is already merged then there’s no need for this issue and we’ll wait for a new release.