question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bump Playwright to 1.1.1

See original GitHub issue

Upgrade it to the latest version.

Blocked by https://github.com/microsoft/playwright/issues/2540

types diff which would work:

diff --git a/src/types.d.ts b/src/types.d.ts
index 1208d12..b115bf8 100644
--- a/src/types.d.ts
+++ b/src/types.d.ts
@@ -1,12 +1,11 @@
 import type {
-  BrowserTypeLaunchOptions,
-  BrowserNewContextOptions,
+  LaunchOptions,
+  BrowserContextOptions,
   WebKitBrowser,
   ChromiumBrowser,
   FirefoxBrowser,
   BrowserType as PlaywrightBrowserType,
-  BrowserTypeConnectOptions,
-  DeviceDescriptor,
+  devices,
 } from 'playwright-core'
 import type { JestDevServerOptions } from 'jest-dev-server'
 import { CHROMIUM, FIREFOX, IMPORT_KIND_PLAYWRIGHT, WEBKIT } from './constants'
@@ -30,22 +29,20 @@ export type SelectorType = {
   name: string
 }
 
-type Devices = { [name: string]: DeviceDescriptor }
-
 export interface Playwright {
   instance: GenericBrowser
-  devices: Devices
+  devices: typeof devices
 }
 
 export type PlaywrightRequireType = BrowserType | typeof IMPORT_KIND_PLAYWRIGHT
 
 export interface Config {
-  launchBrowserApp?: BrowserTypeLaunchOptions
-  context?: BrowserNewContextOptions
+  launchBrowserApp?: LaunchOptions
+  context?: BrowserContextOptions
   exitOnPageError: boolean
   browsers: BrowserType[]
   devices?: string[]
   server?: JestDevServerOptions
   selectors?: SelectorType[]
-  connectBrowserApp?: BrowserTypeConnectOptions
+  connectBrowserApp?: Parameters<GenericBrowser['connect']>[0]
 }

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
mxschmittcommented, Jun 15, 2020

Let’s keep it open until its fixed upstream so we can revert our workaround.

0reactions
mxschmittcommented, Jul 7, 2020

Yep good 👍🏽

Read more comments on GitHub >

github_iconTop Results From Across the Web

odottaa - NPM Package Overview - Socket - Socket.dev
Custom playwright matchers to test the state of the API response. ... chore(deps-dev): bump @playwright/test from 1.25.2 to 1.26.0 (2e446dd) ...
Read more >
chg: Bump deps, fix issue with playwright · 7f1b9f8139 - lookyloo ...
lookyloo - Lookyloo is a web interface allowing to scrape a website and then displays a tree of domains calling each other.
Read more >
@shioencaja/madezza - npm
Playwright : Fast and reliable end-to-end testing. esbuild: Javascript bundler that compiles, bundles and minifies the original Typescript files. Changesets: A ...
Read more >
~haowenl/vision-venture: Bump dependencies - sourcehut git
~haowenl/vision-venture · "format": "prettier --write --plugin-search-dir=. ." · }, · "devDependencies": { · "@playwright/test": "^1.27.1", · "@sveltejs/adapter-auto ...
Read more >
int - River Thames Conditions - Environment Agency - GOV.UK
Top model of audi cars, Restaurant zegels haarlem, Hard jaw bone lump, E-lco, ... Madan no vanadis volume 13, Toca kitchen 1.1.1 ipa,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found