Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The typed array polyfill we provide in dist/ does not polyfill ArrayBuffer.isView

See original GitHub issue

First reported in https://github.com/ropensci/plotly/issues/1055

In our src code, we add a fallback to ArrayBuffer.isView here, but @dfcreative 's color-parse does not. This lead to 3D and gl2d (and anything else using color-rgba) breaking in RStudio even with typed array polyfill we provide in dist/.

So, we could of course patch color-parse to include an isView fallback, this will fix this one case. But maybe instead we could add a ArrayBuffer.isView polyfill to the typedarray.min.js we provide which will solve this problem for all our dependencies.

By the way, does anyone know where typedarray.min.js comes from?

cc @alexcjohnson @cpsievert @bcdunbar

Issue Analytics

State:
Created 6 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

2reactions

etpinardcommented, Jul 26, 2017

Actually, I’ll reopen this issue.

#1915 fixed the issue, but the typed array polyfill we provide in dist/ does not polyfill ArrayBuffer.isView still holds.

1reaction

dycommented, Jul 19, 2017

@etpinard done https://github.com/colorjs/color-parse/commit/4be59c59c9f063b71d87b0c8e8cbde11349c2530#diff-168726dbe96b3ce427e7fedce31bb0bcL164

Top Results From Across the Web

Module not found: Error: Can't resolve 'core-js/es6'

I can solved it if I downgrade core-js version using this line : npm install core-js@2.6.5 , but it is not a good...

ArrayBuffer.isView() - JavaScript - MDN Web Docs

The ArrayBuffer.isView() method determines whether the passed value is one of the ArrayBuffer views, such as typed array objects or a DataView.

web-streams-polyfill - UNPKG

747, if (!ArrayBuffer.isView(view)) {. 748, throw new TypeError('You can only respond with array buffer views');. 749, }. 750, if (view.byteLength === 0) {....

core-js-for-ie8 - npm Package Health Analysis - Snyk

Includes polyfills for ECMAScript 5, ECMAScript 6: promises, symbols, ... ...and it doesn't mean core-js will not work in other engines, they just...

"finansgruppen.com"

_bodyFormData)throw new Error("could not read FormData body as blob");return Promise.resolve(new Blob([this._bodyText]))},this.arrayBuffer=function(){return ...