Support for React 17 (address NPM warns)
See original GitHub issueIs your feature request related to a problem? Please describe. I’m requesting React 17 support. My package.json contains:
"@nivo/bar": "0.64.0",
"@nivo/pie": "0.64.0",
...
"react": "17.0.1",
I don’t know of any actual problems with the library working with React 17, but since updating, when I run npm install I see:
npm WARN @nivo/bar@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/pie@0.64.0 requires a peer of @nivo/core@0.63.1 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/pie@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/annotations@0.64.0 requires a peer of @nivo/core@0.63.1 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/annotations@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/axes@0.64.0 requires a peer of @nivo/core@0.63.1 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/axes@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/colors@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/core@0.64.0 requires a peer of @nivo/tooltip@0.63.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/core@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/legends@0.64.0 requires a peer of react@>= 16.8.4 < 17.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @nivo/tooltip@0.64.0 requires a peer of @nivo/core@0.63.1 but none is installed. You must install peer dependencies yourself.
As well, this dependent library:
npm WARN react-motion@0.5.2 requires a peer of react@^0.14.9 || ^15.3.0 || ^16.0.0 but none is installed. You must install peer dependencies yourself.
^ I don’t see any updated versions of that library since react 17’s release though.
Describe the solution you’d like I’d like to suggest that the relevant package.json files be updated to allow the 17.x versions of React.
Describe alternatives you’ve considered The alternative is to leave this as is since it seems still functionally correct and ignore the warning noise on npm install.
Additional context Just want to say thanks for all the effort that this library has gotten recently.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:3
- Comments:8
Top GitHub Comments
We are seeing the same issue with npm 7.
You can use
npm i --legacy-peer-deps
to workaround it.There shouldn’t be any breaking changes for us in React 17, so I don’t see an issue with the version ranges being updated.
As far as
react-motion
, we are working towards migrating away from it in favor ofreact-spring
. You can track progress in #667.