button: ref isn't passed onto base button element

Bug

Expected behavior

Probably a borderline “bug”. For situations where you need a ref to the base component element, I would expect that setting the ref prop would give back an element.

Workaround: Using innerRef appears to work

Actual behavior

When setting the ref prop to a function, the resulting element returned is null.

setElement = el => {
  // el comes back as null :-(
  this.buttonElement = el
}
...
<Button ref={this.setElement}>Ohai!</Button>

Steps to repro

1. Set ref on the Button component with a callback.
2. Run the app and see that the callback is given null.

Related packages

• button@8.0.1

Environment

• OS - MacOS 10.12
• Browser version - Chrome v60

[jaketrent]

@bressain innerRef should work as before now in button@9.0.3 . Please give it a try and let me know.

[bressain]

Looks like it’s working again, thanks!