Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Throat volume is not accounted for in TransientReactiveTransport class

See original GitHub issue

In TransientReactiveTransport class, under _t_update_A and _t_update_b methods, we only account for pore.volume and not throat.volume. We should distribute throat.volume based on pore.volume. Should be an easy fix, but important one, especially when throat.volume is large enough.

Issue Analytics

State:
Created 3 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

jgostickcommented, Jul 20, 2020

Wow, that helped a lot more that I was expecting. Create a PR, then Stephen can check it out and make sure it works for his problem too before we finally merge it.

0reactions

mkaguercommented, Jul 21, 2020

I created a PR here: #1590

That was my first PR let me know if I didn’t do something right.

Top Results From Across the Web

Review of pore network modelling of porous media

In this review we focus on the pore network models with comprehensive account for the methods for obtaining pore space information, constructing pore...

Porosity–Permeability Relations for Evolving Pore Space

Abstract. Reactive transport processes in a porous medium will often both cause changes to the pore structure, via precipitation and dissolution ...

15. TRANSIENT AND ACCIDENT ANALYSES

The assumption in Case (a) will result in a more limiting transient and, therefore, it is acceptable.

OSHA Technical Manual (OTM) - Section III: Chapter 5

Both are transient noises of brief duration and high intensity. The sound may or may not have a "ringing" quality (such as a...

Relating Darcy-Scale Chemical Reaction Order to Pore-Scale ...

Though not perfect, such a one-dimensional (1D) expression does represent reactive transport in a pore throat in many pore-network models (Algive et al....