Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

webpack version detection should use feature detection

See original GitHub issue

the webpack version is determined using a require, but this is problematic in monorepos where the location of this plugin and the location of webpack can be unexpected.

Is there some way to infer the version we’re dealing with from the compiler passed into apply?

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:26 (9 by maintainers)

Top GitHub Comments

4reactions

pmmmwhcommented, Jun 1, 2021

Hi @ndelangen @rdsedmundo -

I’ve implemented proper version detection and pass-through imports on the compiler instance for Webpack 5 in #415. Would you mind testing it out in your projects?

npm install -D -S git://github.com/pmmmwh/react-refresh-webpack-plugin.git#feat/feature-detection
yarn add -D git://github.com/pmmmwh/react-refresh-webpack-plugin.git#feat/feature-detection
pnpm add -D git://github.com/pmmmwh/react-refresh-webpack-plugin.git#feat/feature-detection

I’ll merge that once I got around to fill out tests for the changes and we can confirm that the PR works in reality.

1reaction

rdsedmundocommented, Jun 1, 2021

It worked for my project. Thanks for working on that! 🎉