WHM support breaks projects that do not have it installed

After upgrading to 0.2.0, I noticed the following error:

ERROR in ./node_modules/@pmmmwh/react-refresh-webpack-plugin/src/runtime/WHMEventSource.js
Module not found: Error: Can't resolve 'webpack-hot-middleware/client' in '[...]/node_modules/@pmmmwh/react-refresh-webpack-plugin/src/runtime'

I believe this is because webpack sees this require when bundling the injected runtime code:

https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/0a6c1149469718bb4b289fc0d6f370db78f84294/src/runtime/WHMEventSource.js#L7

And therefore tries to resolve and bundle that module. This code path isn’t taken when a WDS client has been injected, but webpack doesn’t know this at bundle time. My project doesn’t use WHM so that module doesn’t exist on my machine.

As a temporary workaround, installing WHM (npm i -D webpack-hot-middleware) fixes the issue.

/cc @blainekasten

[iassainov]

Still getting this issue while using webpack dev server 3.8.1.

Here are my dev-server options:

devServer: {
      contentBase: './dist',
      historyApiFallback: true,
      host: '0.0.0.0',
      port: 9002,
      overlay: {
         ....
      },
      proxy: {
         ....
      },
    },

[gaearon]

We could also make this an option, so the user can pass in which integration they are using, and we only load the runtime code for that integration (if they’re using something we don’t support, they could rock their own socket code as per #44 ).

This makes most sense to me. Don’t try to guess it on the client, but let the user pick one statically in config.