NormalPass, SSAOPass: Enable passes to work with flat shading, back side material settings

Is your feature request related to a problem?

When setting a material to use “flatShading” or “BackSide” / “DoubleSide” SSAOPass does not currently work as expected because NormalPass does not respect those settings in the override material.

Describe the solution you’d like

NormalPass should use the “OverrideMaterialManager” and respect the original material “flatShading” and “side” properties.

Describe alternatives you’ve considered

None

Additional context

Here’s a JSFiddle showing the current NormalPass results with the above material settings. The left cube uses “flatShading” with no normals while the right cube is using “side = BackSide”:

https://jsfiddle.net/z4759qL8/1/

Thanks!

[vanruesc]

Thanks for the report!

The NormalPass does make use of the OverrideMaterialManager and the side property should already be handled (see #265). The flatShading property is not supported yet. Handling this property will increase the amount of override materials from 9 to 18. This is, of course, awful, but I think this should be the last property that needs to be accounted for. The override material system is also about to become obsolete relatively soonish, now that the MRT PR has been merged.

I’ll publish a fix for flatShading soon.

[gkjohnson]

Three’s current built-in materials are quite rigid and hard to extend. I think we still have to wait for NodeMaterials and declarative shader manipulation features to actually make effective use of MRT in the RenderPass.

Yes I’m excited to see what Node materials bring. I think they’ll be pretty enabling in a lot of ways.

Thanks for the quick fix!