Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support for 1D LUTs

See original GitHub issue

For three-filmic, I needed a small 1D “shaper” LUT in addition to the larger 3D LUT. The 1D version is really simple, implemented here as LUT1DEffect.ts. Would you be interested in having support for 1D LUTs in this repository? If so, I’d be happy to make a PR. Should it be part of LUTEffect, or separate the two as (for example) LUT1DEffect and LUT3DEffect?

Related — I found that LUTCubeLoader does not currently support 1D .cube LUTs. That’d be pretty easy to add as well, if we’re interested. I wasn’t sure why LUTCubeLoader is forked from the three.js version though — is there an important difference between the two? For bandwidth reasons, I’m planning to eventually switch three-filmic from plaintex .cube LUTs to compressed .ktx2 data textures.

Additional context

Issue Analytics

State:
Created a year ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

donmccurdycommented, Sep 1, 2022

Just as FYI, more details on the KTX2 LUT workflow described above —

https://www.donmccurdy.com/2022/08/31/compressing-luts-with-ktx2/

1reaction

donmccurdycommented, May 25, 2022

Related PRs to three.js:

In tests far, a 130kb .ktx2 file can represent the same 3D LUT (at same precision) as a 880kb .cube file, and it’s much faster to parse. That’s without even using KTX2’s support for Zstandard compression, which could reduce it further. So I may just skip on trying to do any big changes to the three.js or pmndrs LUTCubeLoader and LUT3dlLoader classes at this point.