Bug report: Unhandled exception when trying to add user to a non-existent SharePoint group referred to by ID

Description

When you try to add a user to a non-existent SharePoint group, referring to the group by its ID, we throw an unhandled exception.

Steps to reproduce

m365 spo group user add -u [site_url] --groupId [non-existent group ID] --userName [e-mail]

Expected results

Error: group not found

Actual results

/Users/user/github/pnp/cli-microsoft365/dist/cli/Cli.js:436
                if (JSON.stringify(originalProperties) === JSON.stringify(Object.getOwnPropertyNames(logStatement[0]))) {
                                                                                 ^

TypeError: Cannot convert undefined or null to object
    at Function.getOwnPropertyNames (<anonymous>)
    at Function.formatOutput (/Users/user/github/pnp/cli-microsoft365/dist/cli/Cli.js:436:82)
    at Object.log (/Users/user/github/pnp/cli-microsoft365/dist/cli/Cli.js:164:40)
    at /Users/user/github/pnp/cli-microsoft365/dist/m365/spo/commands/group/group-user-add.js:51:20
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Diagnostics

No response

CLI for Microsoft 365 version

Latest from main

nodejs version

v16.13.0

Operating system (environment)

macOS

Shell

zsh

cli doctor

No response

Additional Info

No response

[waldekmastykarz]

I think in this case we could handle the empty response and assuming it’s an error, show a relevant error message.

[robdy]

Before adding the users to group, you may have to check the presence of the valid SharePoint group in the web

I’m not sure if this is a good idea. We’d potentially add one more request to each command execution, while error handling does not add anything in terms of the performance.

I can imagine it’s not a big deal, though. The question would be - what’s the general approach?

Based on m365 teams team set - we’re not checking whether the team exists before sending patch request. Similarly in m365 teams tab add we’re not checking if the team exists before sending post request.