EnsureFolderAsync troubles

Category

• Bug

Describe the bug

I’m trying to use await folder.EnsureFolderAsync to create nested folder on the fly before adding files in it. File are not upload in the good folder.

Steps to reproduce

You can reproduce with this code.

I’m trying to upload in list with folder in it. /MyList/Daily/Today is working /MyList/Test/Test not working /MyList/Weekly/Test not working and file are in the second folder.

using var context = await _pnpContext.GetContextAsync();
  var folder = (await context.Web.Lists.GetByIdAsync(libraryId, p => p.RootFolder)).RootFolder;
  var suby = await folder.EnsureFolderAsync(CleanFolderName(folderName));
  var subfolder = await context.Web.GetFolderByIdAsync(suby.UniqueId);
await folder.Files.AddAsync(fileName, stream);

 private static string CleanFolderName(string folderName)
    {
        if (folderName.StartsWith("/"))
        {
            return folderName.Remove(0, 1);
        }
        return folderName;
    }

the var suby always return /MyList/Test/Test.

Thank in advance for your help.

[pINKmUNster]

@jansenbe i try with the nightly release and it works as expected. 👍🏻 All my file are upload in the correct folder.

Thank a lot, you rock !!

[jansenbe]

@pINKmUNster : below approach adds the 3 files in the right folder:

                var list = await context.Web.Lists.AddAsync("Bert", ListTemplateType.DocumentLibrary);
                await list.EnsurePropertiesAsync(p => p.RootFolder);

                //var suby = await list.RootFolder.EnsureFolderAsync("Daily/Today");
                //var suby = await list.RootFolder.EnsureFolderAsync("Test/Test");
                var suby = await list.RootFolder.EnsureFolderAsync("MyList/Weekly/Test");

                await suby.EnsurePropertiesAsync(p => p.Files);
                IFile addedFile = await suby.Files.AddAsync("bert.docx", System.IO.File.OpenRead($".{Path.DirectorySeparatorChar}TestAssets{Path.DirectorySeparatorChar}test.docx"));
                IFile addedFile1 = await suby.Files.AddAsync("bert2.docx", System.IO.File.OpenRead($".{Path.DirectorySeparatorChar}TestAssets{Path.DirectorySeparatorChar}test.docx"));
                IFile addedFile2 = await suby.Files.AddAsync("bert3.docx", System.IO.File.OpenRead($".{Path.DirectorySeparatorChar}TestAssets{Path.DirectorySeparatorChar}test.docx"));

Using your code however exposed an issue with the EnsureFolderAsync() method, it did not work when ran on an existing folder. I did not get the same behavior you saw, but adding multiple documents in the same folder failed due to this. I’ve just pushed a fix (https://github.com/pnp/pnpcore/commit/e1947c191e74189a7e9549779944a402da4bc948) for that, will be part of tomorrow’s nightly release.