Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

<FilePicker/> Add properties for default library- & folderPath for <SiteFilePicker/>

See original GitHub issue

Version

3.1.0

Desired Behavior

It would be great if the <FilePicker/> could accept a property/properties for setting a default selected library and folder which would apply to the <SiteFilePicker/> child.

Implementation

I’m up for submitting a Pull Request and I might even take a look into #725 while I’m at it as a multiple file select is applicable for my use case as well.

Right now I’m thinking of just giving a single property named defaultFolderAbsolutePath (perhaps with a suffix to indicate its intention for the SiteFilesTab) and parse it in the <SiteFilePickerTab/> constructor for the state variables (and breadcrumb ofc).

Issue Analytics

State:
Created 2 years ago
Comments:12 (7 by maintainers)

Top GitHub Comments

2reactions

joelfmrodriguescommented, Jun 18, 2021

Well, this is a bit of a different story then 😊 I would be fine with removing unused variables and even rename variables if the name is not indicative of their purpose and confusing. One thing that I would suggest, is that you do this as a separate PR (using a new branch from dev, not your previous branch) as it’s not directly related to the feature you are implementing and can be submitted as a completely isolated improvement to the code

1reaction

AJIXuMuKcommented, Jul 1, 2021

Please don’t close until the version is released.