question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Global radio button styles included in this extension break the display of radio buttons on other webpages

See original GitHub issue

When the ‘Save to Pocket’ browser extension is enabled in Chrome, globally scoped CSS styles for radio buttons override the styles for radio buttons on other webpages, rendering them invisible and unusable.

Please treat this as high priority – I believe this issue may prevent users of this extension from being able to use some websites.

Steps to reproduce

  1. Install the ‘Save to Pocket’ Chrome extension – tested with v4.0.0.
  2. Go to http://govuk-frontend-review.herokuapp.com/full-page-examples/how-do-you-want-to-sign-in

Expected results

The radio buttons on the webpage should not be affected by the ‘Save to Pocket’ Chrome extension, and should look like this:

Screenshot 2021-10-27 at 13 36 27

Actual results

The radio buttons are rendered invisible, and the positioning of the label is also affected. Selecting a radio button changes its appearance, but it is also rendered incorrectly.

Screenshot 2021-10-27 at 13 38 10

You can see in the inspector that this is because the input, the :before and :after pseudo elements, and the label are all being targeted by the injected stylesheet:

Screenshot 2021-10-27 at 13 42 51

The injected styles seem to match those defined in pages/injector/globalStyles.js (which seem to have been introduced for use on the options page in #249):

https://github.com/Pocket/extension-save-to-pocket/blob/4e3f65a7fc0d28e1dcd91b76984263fa7a76c356/src/pages/injector/globalStyles.js#L174-L266

Examples of other affected components

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:22
  • Comments:7 (2 by maintainers)

github_iconTop GitHub Comments

18reactions
anthony-liddlecommented, Oct 27, 2021

Thanks for raising! We’ve put a fix together and submitted it to the Chrome Web Store for review.

The timeline for release is out of our hands at this moment, but it will roll out as an automatic update as soon as it’s approved.

I will update and close this issue once it has been officially released.

https://github.com/Pocket/extension-save-to-pocket/pull/268

3reactions
lwpinioncommented, Oct 27, 2021

Yes, this is a major problem for me. I have disabled the extension for now. There’s a lot of negative reviews on the Chrome Web Store page reflecting that plenty of people are experiencing this.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Styling Radio Buttons with CSS (59 Custom Examples)
Styling radio buttons are elements on many websites. It is normal to see them in use on pages where completion of forms is...
Read more >
Radio Group - Lightning Design System
The ability to style radio buttons with CSS varies across browsers. To ensure that radio buttons look the same everywhere, we use a...
Read more >
Checkboxes vs. Radio Buttons - Nielsen Norman Group
Radio buttons are used when there is a list of two or more options that are mutually exclusive and the user must select...
Read more >
CSS Component: Radio Buttons - If Design System
Radio buttons allow the selection of a single option from a set. This component provides .css , .styl , .less and .scss -files....
Read more >
Radio Buttons and Swatches for WooCommerce
Variations Radio Buttons and Swatches is highly customizable plugin that lets you choose a color and an image for each attribute term, orientation...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found