`py38_images` tests failing after recent merge in Main

🐞 Problem

The Main branch & subsequently all rebased branches on the current main are failing the py38_images test. The problem seems to be that the images from test_porkchop_plotting in test_porkchop.py are different from those in the assertion … The can be seen in the code snippet below as well as this link

=================================== FAILURES ===================================
____________________________ test_porkchop_plotting ____________________________
Error: Image files did not match.
  RMS Value: 23.55042462462195
  Expected:  
    /tmp/tmpi6yv37y_/test_porkchop.test_porkchop_plotting/baseline.png
  Actual:    
    /tmp/tmpi6yv37y_/test_porkchop.test_porkchop_plotting/result.png
  Difference:
    /tmp/tmpi6yv37y_/test_porkchop.test_porkchop_plotting/result-failed-diff.png
  Tolerance: 
    2

💡 Possible solutions

We need to check for the reason why the test is failing in the first place & find the commit that was recently merged leading to failure of the required test. Appropriate changes need to be done if the test has wrong assertion, upload the correct image or revert the commit so as to restructure it with all the tests passing

[astrojuanlu]

These tests are just a way to check internal consistency. I propose that we regenerate the images with latest matplotlib so we can make the tests pass without changing anything else.

To regenerate the images: https://github.com/matplotlib/pytest-mpl/#with-baseline-images

[astrojuanlu]

Fair enough, but first we ought to understand what is the root cause. If we loosen up the tolerance, we might miss legitimate bugs.