Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Raise error in Orbit.from_sbdb when more than one orbit is returned

See original GitHub issue

🐞 Problem

When Orbit.from_sbdb is called with names which are too common, like “Halley” or “*alley”, it returns a keyerror. Raise a suitable warning in those cases.

Code to reproduce error:

Orbit.from_sbdb("Halley")

🖥 Please paste the output of following commands

conda info -a (only if you have conda)
conda list (only if you have conda)
pip freeze

# Paste your output here:

python -c "import poliastro.testing; poliastro.testing.test()"

# Paste your output here:

🎯 Goal

Related to #534 To make from_sbdb more user friendly.

💡 Possible solutions

📋 Steps to solve the problem

Comment below about what you’ve started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

Issue Analytics

State:
Created 5 years ago
Comments:10 (9 by maintainers)

Top GitHub Comments

2reactions

Ivan9528commented, Apr 17, 2019

Hi @michiboo!! It is already solved actually, I just have to make the pull request but the coding is done, I will do it tonight if time allows me to 😄 Thanks!!

1reaction

Ivan9528commented, Apr 17, 2019

Yes, I run it and it raises the error as the previous coder already did but changing slightly the coding. I am going to try to make the pull request so that you any can review it 😄