question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove internal uses of deprecated Orbit.from_body_ephem

See original GitHub issue

Doing a quick search, the only place where we are using Orbit.from_body_ephem is this one:

https://github.com/poliastro/poliastro/blob/6ee8e9386a27d4d241cd0e9cb22f6fb6fbf2cf45/src/poliastro/plotting/_base.py#L372-L374

Instead, we should instead be doing this:

    ephem = Ephem.from_body(body, J2000_TDB)
    orbit = Orbit.from_ephem(Sun, ephem, J2000_TDB)

And, after that, tests covering Orbit.from_body_ephem can be removed.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
astrojuanlucommented, Jan 28, 2021

Good catch @Yash-10 !

0reactions
astrojuanlucommented, Feb 14, 2021

@ishanSrt The function has already been deprecated, there are no more changes needed to its function definition and docs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Remove deprecated Orbit.from_body_ephem and its tests
Usage Workflow file. Triggered via pull request 2 years ago. @ishanSrt ishanSrt. synchronize #1110 · ishanSrt:remove-deprecated-Orbit.from_body_ephem.
Read more >
1 Enhanced Deprecation - Java
A newer, better API can be used instead. The deprecated API is going to be removed. In prior releases, APIs were deprecated but...
Read more >
When are API methods marked "deprecated" actually going ...
It is recommended that programs be modified to eliminate the use of deprecated APIs, though there are no current plans to remove such...
Read more >
Tempo for Server Code Deprecation and Removal
Deprecated API Path / Location Public? Use Case POST worklog attributes /rest/tempo‑rest/2.0/worklogs//attributes No Update work attrib... GET worklog attributes /rest/tempo‑core/1/work‑attribute/value Yes Get all work attrib... POST...
Read more >
How long to wait before deleting a deprecated method?
Major version releases are a good time to remove deprecated methods. ... I worked for a company developing software for internal use.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found