Return times in Orbit.sample

🐞 Problem

Sampling an orbit was introduced in #263, and it just returns a CartesianRepresentation object:

https://github.com/poliastro/poliastro/blob/v0.8.0/src/poliastro/twobody/orbit.py#L315

It would be nice to return the time values as well.

🎯 Goal

Just sampling the positions is enough for things like plotting, but any application that needs to analyze the results would benefit from having the times as well.

💡 Possible solutions

• Return a tuple times, positions
• Return a new type of object (Trajectory?)

Notice that both of these break the API. Any solution that returns different things depending on an optional parameter won’t be accepted.

📋 Steps to solve the problem

• Comment below about what you’ve started working on.
• Add, commit, push your changes
• Submit a pull request and add this in comments - Addresses #<put issue number here>
• Ask for a review in comments section of pull request
• Celebrate your contribution to this project 🎉

[astrojuanlu]

That would be a correct implementation, but I still think Orbit.get_times makes no sense. I’d prefer to return a tuple (times, positions) than have a get_times method. Of course if you want to contribute it, you’re invited to do so 😃

[astrojuanlu]

Closed in #312.