Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

“An <body> tag”

See original GitHub issue

Do the correct “A” vs. “An” in error messages. I suspect i18next has an affordance for this.

Issue Analytics

State:
Created 7 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

schrajcommented, Apr 11, 2017

sure, I’ll do this in the next couple of days.

On Sun, Apr 9, 2017 at 8:51 AM, Mat Brown notifications@github.com wrote:

@schraj https://github.com/schraj this is a really cool proposal! My only (fairly superficial) feedback:

I like the idea of including en- in the formatter name for self-documentation, but I don’t think we would need the check in the format function, since presumably the formatter would only be referenced in English translation files, right?

Is it possible to compose two formatters? Seems like it would be nice to decouple the capitalization from the a/an of it all

That being said, I think this is a really clever approach and I’d love to go for it. Are you down to cook up a PR along those lines?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/popcodeorg/popcode/issues/375#issuecomment-292794029, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUV-_Vo0w14G0yDrhgP8SR7TmxbwE1Lks5ruP6CgaJpZM4Kdtjn .

0reactions

outoftimecommented, Apr 25, 2017

@schraj it’s out! I noticed there are several more messages in the translations file that would benefit from this—would you be down to follow up? I can handle if you’ve had enough a/an for now : )