Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

decl. node important boundaries

See original GitHub issue

Similar to (#598), If a declaration value ends with a comment along with !important, that comment will be considered as part of node.important rather than being part of node.raws.value.

For example:

body {
 font-family:Tahoma/*comment*/!important;
}

Produces:

{ raws:
  { 
     before: '\n',
     between: ': ',
     important: '/*comment*/!important'
  }
}

While it is expected to be:

{ raws:
   { 
     before: '\n',
     between: ':  ',
     important: '!important',
     value:{
        raw: 'Tahoma /*comment*/',
        value: 'Tahoma',
     }
   }
}

Shouldn’t the comment be part of the value ?

Thanks.

Issue Analytics

State:
Created 7 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

aicommented, Feb 8, 2017

Sure. It is issue. I will fix it in next few weeks. Feel free to ping me on Sunday.

0reactions

MohammadYounescommented, Mar 14, 2017

@ai in case the comment was placed after !important it will produce:

{ raws:
  { 
     before: '\n',
     between: ': ',
     important: '!important/*comment*/'
  }
}

https://runkit.com/5834c46bd8fb6400141ac375/58c84fe87474fc0014f16da2

Top Results From Across the Web

TSConfig Reference - Docs on every TSConfig option

From allowJs to useDefineForClassFields the TSConfig reference includes information about all of the active compiler flags setting up a TypeScript project.

How To Use Every Node in Unity Shader Graph - Daniel Ilett

This tutorial shows you every single node in action, ... Occlusion can be used to add slight shadows around object boundaries (see left)....

node-red-contrib-web-worldmap 2.32.0

A Node-RED node to provide a world map web page for plotting "things" on. Map Image. Updates. v2.32.0 - Change || to nullish...

Launch template support - Amazon EKS - AWS Documentation

The opening boundary, which signals the beginning of a user data block – --==MYBOUNDARY== The content type declaration for the block: Content-Type: text/cloud- ......

Chapter-15-Network-Linear-Programs ... - AMPL

two kinds: simple bounds on the flows, and conservation of flow at the nodes. Models restricted in this way give rise to the...