Deeply nested properties do not trigger template getter on rollback

Version

2.0.0

Test Case

https://github.com/neighborly/changeset-test

Steps to reproduce

We are building a generalized form component based on ember-changeset that yields a set of input fields that are automatically bound to the changeset by a fieldName property. The value of these inputs is bound by a template getter to the this.fieldName property within the changeset, and onInput is bound to action (changeset-set this.changeSet this.fieldName) value="target.value". The changeset picks-up on the changes to the input; however, when the form is reset, the changes clear from the changeset, but the inputs do not reset their values.

It seems like the {{get}} helper only binds to the first token in a complex property key. This does not happen on properties that are at the top-level of the changeset model. For example, this will occur on a name.first property, but not on a email property.

Here is a demo app that illustrates the idea: https://github.com/neighborly/changeset-test

In this demo app change both of the values in the inputs, and click the reset button. You will only see the email field reset.

Expected Behavior

Expected behavior is that any property would update when reset.

Actual Behavior

Actual behavior is that the deeply nested properties do not update when reset.

[rreckonerr]

That’s the solution

  init(...args) {
    this._super(...args)

    defineProperty(
      this,
      'value',
      computed(`model.${this.attribute}`, `model.{_content,_changes}` {
        get() {
          const model = get(this, 'model')
          return isChangeset(model) ? model.get(this.attribute) : get(this, `model.${this.attribute}`)
        },
        set(_, value) {
          const model = get(this, 'model')
          isChangeset(model) ? model.set(this.attribute, value) : set(this, `model.${this.attribute}`, value)
          return value
        }
      })
    )
  }

[hoIIer]

hey, using latest 2.1.2 with {{changeset-get}} and having same issue where a nested key isn’t being updated after it’s changed.

e.g. new Changeset({ params: { query: '' }}), <input value={{changeset-get changeset "params.query"}}> If I mutate the value of changeset.get(‘params.query’), the input in the template will not update. Any ideas?

also here is a way to spy on a dynamic dependent key in:

    init() {
      super.init(...arguments);

      // define dynamic computed selected at runtime.
      defineProperty(this, 'selected', computed(`changeset.${this.name}`, {
        get() {
          if (this.changeset) {
            return this.changeset.get(this.name);
          }
          return null;
        },
      }));
    }