Problem with quotes still present ? error 500 json.decoder.JSONDecodeError

Hi,

I read than some pull say this was fixed, but when you add DNS template and forget add quotes to TXT record, this template dont working more

When you apply this template to domain, that domain just have 0 records and admin interface stop working with error 500.

There is any patch for this ?

To reproduce:

-> dns template -> add any template -> add txt record SPF / DKIM or any orther, in data just add o=- and save

Then add domain and select this template.

Domain was added without records, and backend get error 500:

json.decoder.JSONDecodeError
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 167 (char 166)

Interface stop working until clean history or delete problematic record:

| 688 | Failed to apply template MMT-CD35-118 to test600.com. | {'status': 'error', 'msg': 'Record _domainkey.test600.com./TXT o=-: Parsing record content (try pdnsutil check-zone): Data field in DNS should start with quote (") at position 0 of o=-'}

Get interface back if that history record was deleted:

delete from history where id=688;

There is any fix for this ?

I check that this was merged in 2021 https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/1060 and https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/1064 but problem still present ?

[jbe-dw]

Hello @AdvanticGmbH ,

Thank you for the PR. We let @vmarkop or @kkmanos review your changes, as they are the original contributors for the detailed history function.

[RGanor]

@Skamasle @jbe-dw The problem reproduced on our environment, although we are not using the master but im close enough in the version, and know the changes since, to be 95% sure it will also reproduced on the master. Im trying to isolate this issue to see the exact history entry that caused this exception in json.loads at: https://github.com/PowerDNS-Admin/PowerDNS-Admin/blob/35f2fde0a833739cdb8fcc16f4993518adc8abff/powerdnsadmin/routes/admin.py#L769