Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix CA2014: Stackalloc in loops

See original GitHub issue

We currently suppress warnings of CA2014 in parts of the build. stackallocs in loops can cause stack overflows, so we need to refactor our code to fix this.

See:

https://github.com/PowerShell/PowerShell/blob/78d0d0e3065d946a1f17cc97cf29b94c12ce9c9f/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleControl.cs#L2579

https://github.com/PowerShell/PowerShell/blob/78d0d0e3065d946a1f17cc97cf29b94c12ce9c9f/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs#L308

https://github.com/PowerShell/PowerShell/blob/78d0d0e3065d946a1f17cc97cf29b94c12ce9c9f/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs#L787-L788

Suppression added in https://github.com/PowerShell/PowerShell/pull/13530

Issue Analytics

State:
Created 3 years ago
Comments:9 (1 by maintainers)

Top GitHub Comments

2reactions

iSazonovcommented, Aug 28, 2020

For 1 case. StackAlloc is used only (1) ~for large output~, (2) if new line is needed, (3) once on last iteration - so we could add comment that it is safe to suppress.

For 2 case. We can move StackAlloc out the cycle.

For 3 case. We can remove the cycle and replace break-s with return-s.

2reactions

daxian-dbwcommented, Aug 27, 2020

Both first and second are real loops, no?