[2021.4.1-preview] Unusual Control Characters In SSH Session

Issue Type: Bug

ANSI escape characters show up in SSH remoting sessions in integrated console.

• Does not happen in dedicated terminal (non-integrated)
• Downgrading to 2021.2.1 seems to resolve the issue however it is intermittent and not readily reproducible, seems to occur when a lot of text is scrolled across the terminal at once.

Also observed here: https://twitter.com/Phatmandrake/status/1380171258998980612

Extension version: 2021.2.1 VS Code version: Code - Insiders 1.56.0-insider (bb90ba3d5a5f8d114045b045f3bbe1ebc404f54a, 2021-04-07T12:30:14.880Z) OS version: Windows_NT x64 10.0.19043 Fetching remote diagnostics for ‘ssh-remote+tinycloud’ timed out. Remote OS version: Linux x64 5.4.0-66-generic

System Info

Item	Value
CPUs	AMD Ryzen 7 4700U with Radeon Graphics (8 x 1996)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.37GB (3.14GB free)
Process Argv	–folder-uri file:///c%3A/Users/JGrote/Projects/Press --crash-reporter-id 4453efaa-0821-4555-88e2-3de8bad9109e
Screen Reader	no
VM	0%

Fetching remote diagnostics for ‘ssh-remote+tinycloud’ timed out.

Item	Value
Remote	SSH: tinycloud
OS	Linux x64 5.4.0-66-generic
CPUs	Intel® Xeon® CPU E5-2695 v2 @ 2.40GHz (4 x 2399)
Memory (System)	4.33GB (0.81GB free)
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
wslfolderdoccf:30278406
vsget980:30283264
vspre833cf:30267465
pythonptprofiler:30281269
vscnewfiletext:30280636
vshan820cf:30276953
pythondataviewer:30285072
vscus158cf:30286554

[andschwa]

Thanks to @Tyriar there is a workaround https://github.com/microsoft/vscode/issues/120352#issuecomment-817816959 while this bug is being investigated:

"terminal.integrated.localEchoLatencyThreshold": -1

[JustinGrote]

And before you ask I tried without my custom prompt as well, it still happens, additional reproduction in the twitter link from someone else who had the problem in a non-SSH environment (I believe) 😃