Integrated console hangs if PSReadline sets AddToHistoryHandler

I’m running preview but I think this may be in the release as well. psreadline can save your passwords to its plaintext log. To prevent this leeholmes put out a little fragment

        Set-PSReadLineOption -AddToHistoryHandler {
            param([string]$line)
            $sensitive = "password|asplaintext|token|key|secret"
            return ($line -notmatch $sensitive)
        }

I found this was hanging my Intergrated console (but not a PowerShell terminal) in VS Code.

easy to repro ensure you have the integrated console selected. Run a command. paste in Set-PSReadLineOption -AddToHistoryHandler {param([string]$line) return $true} Re-run the previous command

This may be a psreadline bug but it only occurs in the integrated console.

[jhoneill]

@andschwa In the current version this problem has gone away. Obvious it’s been around for a while and I haven’t kept checking it so I can’t say if it was a recent change that fixed it but this can be closed now.

[rjmholt]

Thinking about this, we may need to override Set-PSReadLineOption to intercept parameters that run scriptblocks and turn them into callbacks back into PSES to run things on the pipeline thread.

However that’s rather complex, so I’m not going to attempt it immediately. Also, @daxian-dbw might have a better idea here.