Language-Specific editor.* Settings Ignored When Formatting Document

System Details

• Operating system name and version: Windows 10 1703 (15063)
• VS Code version: 1.15.1
• PowerShell extension version 1.4.1:
• Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.1.15063.502
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.502
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

• Output from code -v:

1.15.1
41abd21afdf7424c89319ee7cb0445cc6f376959

• Output from $psEditor.EditorServicesVersion:

Major  Minor  Build  Revision
-----  -----  -----  --------
1      4      1      0

• Output from code --list-extensions --show-versions:

ms-vscode.PowerShell

Issue Description

PSDocumentFormattingEditProvider.getEditorSettings does not currently consume language-specific editor settings, if defined.

I have fixed this on a local copy of the extension by replacing "editor" with "powershell" in the call to vscode.workspace.getConfiguration, but I am not familiar enough with the language and environment to determine if this is a proper solution.

Full replication steps with description of practical impact are in this (rightfully) closed VSCode issue.

[jimp02]

I have this problem also.

In the user settings file I have: “editor.insertSpaces”: false,

Then a powershell configuration override with: “[powershell]”: { “editor.insertSpaces”: true },

When I select “Format Document” in the context menu, the file is formatted with tabs. The powershell configuration override setting is ignored.

[SydneyhSmith]

Closing as the PR has been merged…thanks for the fix @tillig!!