Taiko Major Barlines are too arbitrary

Currently, the BarLineGenerator uses Major = currentBeat % (int)currentTimingPoint.TimeSignature == 0 to determine whether or not a barline is major (has triangles above and below), with currentBeat incrementing each measure and starting at 0 whenever a new timing point is reached.

This is problematic for a few reasons:

1. Major barlines may not necessarily line up with the time signature. A song in 4/4 may not have major beats every 4 measures, nor does this necessarily apply to any other time signature.

2. Timing points do not necessarily occur on major beats. In these cases, even if the song’s major beats theoretically line up, every single major bar line would be incorrect. In the case of songs with variable bpm, this also results in far more major barlines than necessary.

I don’t think there is a simple solution that guarantees these major barlines won’t be incorrect, when taking into account songs with awkward pauses, or simply no clear pattern at all. The only method that guarantees no errors would be making it something mappers do, but this wouldn’t solve the problem for older maps, in addition to requiring some sort of additional information attached to (effect? timing?) points, as well as a relatively significant amount of extra effort (in the cases of more complex songs, perhaps requiring every major barline to be marked individually?) on the part of mappers for very little benefit in terms of map quality.

Perhaps these major barlines could be something mappers can choose to add for emphasis, but I don’t think auto-generating them is the right answer, which often places emphasis on random barlines that may have nothing on them at all.

[peppy]

4:4 songs will have bars ever 4 beats. That’s how music works. They should be correct for correctly made beatmaps. Not sure this requires action?

[Alchyr]

That makes sense to me