Question of the span decorator

Hi, I am confused with this code, why context.with use context.active ?

In my opinion it will cause parentSpan always be the rootSpan without context.with in the code.

const currentSpan = trace.getSpan(context.active());
const tracer = trace.getTracer('default')

return context.with(trace.setSpan(context.active(), currentSpan), () => {
  // ...
});

I think it should be

const tracer = trace.getTracer('default')
const span = tracer.startSpan(
  name || `${target.constructor.name}.${propertyKey}`,
);

return context.with(trace.setSpan(context.active(), span), () => {
  // ...
});

For example

class Test {
  @Span()
  f1() {
    // ...
  }

  @Span()
  f2() {
    this.f1();
  }
}

current Span decorator won’t let f1 be the child of f2

Thanks for your help.

[pragmaticivan]

Howdy! I will take a look at it today, sorry about the delay!

[mentos1386]

@pragmaticivan i cant say if it only happens when not using controllers, but in my case yes.

It’s not called by “rest” or “graphql” but it’s part of AWS SQS in our case. So there is no instrumentation from controllers, but there is instrumentation by the aws-sdk (the first two spans on my previous comment with image).