Replace_more() AssertionError After Refreshing Comment

Describe the bug

Using the replace_more() function on a comment’s replies after the comment has been refreshed raises an AssertionError. This only happens on certain submissions and I’m not sure why (the code below is an example of a submission that fails). Also, the AssertionError is not raised if the refresh() function is not called on the comment.

To Reproduce Run this code after replacing your client_id, client_secret, and user_agent.

import praw

reddit = praw.Reddit(
    client_id="YOUR-CLIENT-ID",
    client_secret="YOUR-CLIENT-SECRET",
    user_agent="YOUR-USER-AGENT",
)

submission = reddit.submission(id="6aeian")

submission.comment_sort = "confidence"
submission.comments.replace_more()
comments = submission.comments.list()

for comment in comments:
    comment.reply_sort = "confidence"
    comment.refresh()

    # Errors on line below
    comment.replies.replace_more()

Expected behavior

I expected this to run without raising any exceptions.

Code/Logs

Traceback (most recent call last):
  File "/mnt/c/Users/<NAME>/Documents/GitHub/Reddit-Bot/test_praw.py", line 19, in <module>
    comment.replies.replace_more()
  File "/mnt/c/Users/<NAME>/Documents/GitHub/Reddit-Bot/Reddit-Bot/lib/python3.6/site-packages/praw/models/comment_forest.py", line 177, in replace_more
    self._insert_comment(comment)
  File "/mnt/c/Users/<NAME>/Documents/GitHub/Reddit-Bot/Reddit-Bot/lib/python3.6/site-packages/praw/models/comment_forest.py", line 69, in _insert_comment
    assert comment.name not in self._submission._comments_by_id
AssertionError

System Info

• OS: WSL running Ubuntu 18.04.3 LTS
• Python: 3.6.9
• PRAW Version: 6.4.0

[PythonCoderAS]

Replace_more is destructive, so why not create a new Comment and then replace_more that? You can make it a function.

def get_morecomment_count(forest):
    morecount = 0
    for comment in forest:
        if isinstance(comment, MoreComments):
            morecount += 1
submission.comments.replace_more(limit=get_morecomment_count(submission.comments))
comment = submission.comments[0] # example comment
new_comment = reddit.comment(id=comment.id)
comment.replies.replace_more(limit=get_morecomment_count(comment.replies))

[PythonCoderAS]

@tchanxx your error is calling both submission.comments.replace_more() and comment.replies.replace_more(). Since they share the same root submission, this caused the error. If you need to retrieve replies, create a new instance of a comment through the reddit instance.