Avoiding "Duplicate module"

If you have two modules with the same name in the project (but in different packages!) this hook will fail with --all-files supposingly because pre-commit will pass a list of individual files there.

Not sure what the proper solution should be but it seems like a good idea to have something like --all-files=./folder on the hook runner side allowing the user to pass a folder there or maybe an extra option in the hook definition for that dir.

https://github.com/python/mypy/issues/4008#issuecomment-434869336

pre-commit run-test: commands[0] | python3 -m pre_commit run mypy --all-files -v
[mypy] mypy..............................................................Failed
hookid: mypy

octomachinery/app/action/config.py: error: Duplicate module named 'config' (also at 'octomachinery/app/server/config.py')

@asottile what do you think?

[asottile]

but, if you want what you’re suggesting, there’s already a way to do that:

-   repo: ...
    rev: ...
    hooks:
    -   id: mypy
        name: mypy (server)
        files: ^server/
    -   id: mypy
        name: mypy (client)
        files: ^client/

for example

[asottile]

this is usually due to mypy not really understanding PEP420 namespaces – usually the fix is to add __init__.pyi or __init__.py files